Skip to content

Commit 893c508

Browse files
authored
Change minimum versions of Node and eslint in integration tests (#83)
Node v16 is out of support. So we test against Node v18 and v20. eslint 7 was released 4 years ago so its fair to not actively test again eslint 6. Speculativiely adding eslint 9 tests but not sure if that will work Also fix testing of multiple eslint versions We weren't doing custom installations of different eslint versions so we were always only testing one eslint version! Added eslint-v9 test directory but it fails right now so not adding it to CI.
1 parent e4a5603 commit 893c508

File tree

9 files changed

+4152
-1595
lines changed

9 files changed

+4152
-1595
lines changed

.github/workflows/node.js.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616

1717
strategy:
1818
matrix:
19-
node-version: [12.x, 14.x, 16.x]
19+
node-version: [18.x, 20.x]
2020
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
2121

2222
steps:
@@ -29,7 +29,7 @@ jobs:
2929
- run: npm ci
3030
- run: npm run lint
3131
- run: npm run test
32-
- run: npm run integration test 6 7 8 # eslint versions
32+
- run: npm run integration test 7 8 # eslint versions
3333
- name: Upload coverage to Codecov
3434
uses: codecov/codecov-action@v2
3535
with:

0 commit comments

Comments
 (0)