Skip to content

Commit 4952d9f

Browse files
committed
chore: remove unneeded electron-builder flags
Drop the electronFuses block, win.verifyUpdateCodeSignature, and win.signAndEditExecutable added in #3740. None of them are required for the ssh2 tunnel to work: - ssh2's native bindings (sshcrypto.node, cpufeatures.node) are auto-unpacked by Electron and don't conflict with default fuses. - onlyLoadAppFromAsar only governs the entry point (main.js), which stays inside the asar. - Embedded asar integrity validation is handled correctly by modern electron-builder, including for asarUnpack entries. - verifyUpdateCodeSignature only matters when electron-updater is active; Keira3 doesn't ship the auto-updater. - signAndEditExecutable: false skipped not only signing (which electron-builder skips automatically without a cert) but also rcedit, which means the portable .exe shipped without its icon or version metadata. Letting it run by default restores both.
1 parent 879c904 commit 4952d9f

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

electron-builder.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,9 @@
55
"output": "release/"
66
},
77
"files": ["dist/browser/**/*", "main.js", "main.js.map"],
8-
"electronFuses": {
9-
"enableEmbeddedAsarIntegrityValidation": false,
10-
"onlyLoadAppFromAsar": false
11-
},
128
"win": {
139
"icon": "dist/browser",
14-
"target": ["portable"],
15-
"signAndEditExecutable": false,
16-
"verifyUpdateCodeSignature": false
10+
"target": ["portable"]
1711
},
1812
"mac": {
1913
"icon": "dist/browser",

0 commit comments

Comments
 (0)