Skip to content

Commit c1fc9b7

Browse files
sogladevHelias
andauthored
fix(item): format negative resistances (#3696)
Co-authored-by: Helias <stefanoborzi32@gmail.com>
1 parent 26a1871 commit c1fc9b7

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

libs/features/item/src/item-template/item-preview.service.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -813,6 +813,11 @@ describe('ItemPreviewService', () => {
813813
template: { holy_res: 1, arcane_res: 1 },
814814
output: `<br>+1 Holy Resistance<br>+1 Arcane Resistance`,
815815
},
816+
{
817+
name: 'Negative resistance',
818+
template: { holy_res: -5 },
819+
output: `<br>-5 Holy Resistance`,
820+
},
816821
{
817822
name: 'Gem Enchantment - success',
818823
template: { entry: 100 },

libs/features/item/src/item-template/item-preview.service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,8 +1022,9 @@ export class ItemPreviewService {
10221022
// magic resistances
10231023
resistanceFields.forEach((rowName, idx) => {
10241024
const resField = itemTemplate[rowName + '_res'];
1025-
if (rowName != null && resField != null && resField !== 0) {
1026-
magicRsistances += `<br>+${resField} ${ITEM_CONSTANTS.resistances[idx]}`;
1025+
if (rowName != null && resField != null && Number(resField) !== 0) {
1026+
const num = Number(resField);
1027+
magicRsistances += `<br>${num > 0 ? '+' + num : String(num)} ${ITEM_CONSTANTS.resistances[idx]}`;
10271028
}
10281029
});
10291030

0 commit comments

Comments
 (0)