Ensure TypingIndicator wraps correctly with very long names#1123
Ensure TypingIndicator wraps correctly with very long names#1123JamesBurnside merged 13 commits intomainfrom
Conversation
JamesBurnside
requested review from
PorterNan,
alcail,
alkwa-msft,
anjulgarg,
mgamis-msft and
prprabhu-ms
as code owners
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
3 similar comments
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| * @param vars - Variables to use to format the string | ||
| * @returns formatted JSX elements | ||
| */ | ||
| const formatInlineElements = (str: string, vars: _IObjectMap<JSX.Element>): JSX.Element[] => { |
There was a problem hiding this comment.
why removing this from utils file and adding it here?
It might be used elsewhere in the future
There was a problem hiding this comment.
The reason was it wasn't used anywhere else and keeping it here would mean adding fluentui/react dependency to the acs-common package. Happy to move it back and add this dependency if people would prefer though!
There was a problem hiding this comment.
(Ideally this is only used by react-components package as its a very specialized util fn, but there is a chance it could be used by composites - but we should try keep good functionality in the react-components package instead of composites to pass value onto other developers)
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
3 participants
What
Ensure the typing indicator can handle long names/strings by wrapping.
Why
Caused horizontal scrollbars before this
How Tested
Long names:
Normal names: