Immediately fetch initial chat data in adapter (+fix customDataModel flakey UI test)#1168
Merged
JamesBurnside merged 2 commits intomainfrom Nov 26, 2021
Conversation
JamesBurnside
requested review from
PorterNan,
alcail,
alkwa-msft,
anjulgarg,
mgamis-msft and
prprabhu-ms
as code owners
alkwa-msft
approved these changes
Nov 25, 2021
Contributor
alcail
approved these changes
Nov 26, 2021
Member
Author
|
Completing this, cc @PorterNan for any issues this may cause |
JamesBurnside
deleted the
jaburnsi/immediately-fetch-initial-chat-data-in-adapter
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When creating chatAdapter, immediately call
chatAdapter->fetchInitialData()Why
Otherwise you can create a chat composite with missing information
Caveats
Fixes
Flakey ui test where previous messages hadn't loaded before screenshot was taken:
