Dmceachernmsft/MeetingControlBarBooleanType by dmceachernmsft · Pull Request #1266 · Azure/communication-ui-library

dmceachernmsft · 2021-12-20T20:59:11Z

What

Added to the MeetingCallControlOptions prop to allow a False boolean value.

Why

Adds functionality to hide the whole control bar for the call in the meeting composite.

added as per request in comment:

How Tested

ran sample in story book with different combinations of props.

meetingCallOptions to hide whole bar.

github-actions · 2021-12-20T21:04:37Z

Storybook URL https://60c7ae6891f0e90039d7cd54-frqljedflx.chromatic.com/

github-actions · 2021-12-20T21:04:41Z

Storybook URL https://60c7ae6891f0e90039d7cd54-skcbpnwrda.chromatic.com/

github-actions · 2021-12-20T21:05:36Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

button hide when false is given as options prop

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

github-actions · 2021-12-20T21:33:00Z

Storybook URL https://60c7ae6891f0e90039d7cd54-jwzpoqtsda.chromatic.com/

github-actions · 2021-12-20T22:50:52Z

Storybook URL https://60c7ae6891f0e90039d7cd54-fvcibwztal.chromatic.com/

github-actions · 2021-12-20T22:51:59Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T00:45:46Z

Storybook URL https://60c7ae6891f0e90039d7cd54-icrfagksxz.chromatic.com/

github-actions · 2021-12-21T00:46:42Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

Calling composite logic.

github-actions · 2021-12-21T20:34:22Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ghvitrewwm.chromatic.com/

github-actions · 2021-12-21T20:36:34Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T20:57:28Z

Storybook URL https://60c7ae6891f0e90039d7cd54-rohueuxkzs.chromatic.com/

prprabhu-ms · 2021-12-21T21:06:24Z

    // (undocumented)
    meetingAdapter: MeetingAdapter;
-    meetingCallControlOptions?: MeetingCallControlOptions;
+    meetingCallControlOptions?: boolean | MeetingCallControlOptions;


Yeah, let's do that as a follow up PR regardless.

github-actions · 2021-12-21T22:10:07Z

Storybook URL https://60c7ae6891f0e90039d7cd54-mocwyfqxrv.chromatic.com/

github-actions · 2021-12-21T22:10:22Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T22:44:16Z

Storybook URL https://60c7ae6891f0e90039d7cd54-rokqammmlj.chromatic.com/

github-actions · 2021-12-21T22:44:24Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

composite.

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

github-actions · 2021-12-21T23:05:25Z

Storybook URL https://60c7ae6891f0e90039d7cd54-yamirnthbo.chromatic.com/

github-actions · 2021-12-21T23:05:54Z

Storybook URL https://60c7ae6891f0e90039d7cd54-tcvvklousz.chromatic.com/

github-actions · 2021-12-21T23:06:04Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T23:06:25Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T23:07:25Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-21T23:07:30Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

This reverts commit b66abf8. spaces are needed.

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

github-actions · 2021-12-21T23:20:51Z

Storybook URL https://60c7ae6891f0e90039d7cd54-jdmodzntlt.chromatic.com/

github-actions · 2021-12-21T23:21:28Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2021-12-22T00:50:26Z

Storybook URL https://60c7ae6891f0e90039d7cd54-fabnqtahxg.chromatic.com/

dmceachernmsft added 4 commits December 18, 2021 02:27

added boolean type to meetingCallControlOptions.

e3a5a0f

added fix to allow for false value for

06c6f63

meetingCallOptions to hide whole bar.

Change files

e35c72f

updated API docs and changelogs

78474d6

dmceachernmsft requested review from JamesBurnside, PorterNan, alcail, alkwa-msft, anjulgarg, mgamis-msft and prprabhu-ms as code owners December 20, 2021 20:59

github-actions Bot added the breaking-change label Dec 20, 2021

Merge branch 'main' into dmceachernmsft/MeetingControlBarBooleanType

43c4ebf

dmceachernmsft commented Dec 20, 2021

View reviewed changes

Comment thread packages/react-composites/src/composites/CallComposite/components/CallControls.tsx Outdated

dmceachernmsft added 3 commits December 20, 2021 21:09

made chat and people

30fa291

button hide when false is given as options prop

Merge branch 'dmceachernmsft/MeetingControlBarBooleanType' of https:/…

f1c1c48

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

added missing dependancy.

4bd22ed

Merge branch 'main' into dmceachernmsft/MeetingControlBarBooleanType

0c4f0b3

prprabhu-ms reviewed Dec 20, 2021

View reviewed changes

Comment thread .github/workflows/nightly-cd.yml Outdated

Merge branch 'main' into dmceachernmsft/MeetingControlBarBooleanType

3f05cef

dmceachernmsft added 2 commits December 21, 2021 00:47

removed merge conflict lines from nightly-cd file.

5e3b58b

Merge branch 'dmceachernmsft/MeetingControlBarBooleanType' of https:/…

a1286f8

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

Updated internal logic to better match

b3a7e74

Calling composite logic.

fixed linting errors

065020c

prprabhu-ms approved these changes Dec 21, 2021

View reviewed changes

Changes to resolve comments.

388558e

anjulgarg approved these changes Dec 21, 2021

View reviewed changes

Merge branch 'main' into dmceachernmsft/MeetingControlBarBooleanType

ffe95eb

dmceachernmsft added 3 commits December 21, 2021 23:01

removed CSS making a space in meeting

b66abf8

composite.

Merge branch 'dmceachernmsft/MeetingControlBarBooleanType' of https:/…

8fe094c

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

Merge branch 'main' into dmceachernmsft/MeetingControlBarBooleanType

a2c8c02

dmceachernmsft added 2 commits December 21, 2021 23:15

Revert "removed CSS making a space in meeting"

45cbc1e

This reverts commit b66abf8. spaces are needed.

Merge branch 'dmceachernmsft/MeetingControlBarBooleanType' of https:/…

7eb6e0c

…/github.com/Azure/communication-ui-library into dmceachernmsft/MeetingControlBarBooleanType

fixed mystery spacing.

40db041

dmceachernmsft merged commit 3217608 into main Dec 22, 2021

dmceachernmsft deleted the dmceachernmsft/MeetingControlBarBooleanType branch December 22, 2021 00:53

Conversation

dmceachernmsft commented Dec 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How Tested

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

github-actions Bot commented Dec 20, 2021

Uh oh!

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

prprabhu-ms Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 21, 2021

Uh oh!

github-actions Bot commented Dec 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dmceachernmsft commented Dec 20, 2021 •

edited

Loading