Skip to content

Dmceachernmsft/MeetingCompositeOptions#1272

Merged
dmceachernmsft merged 18 commits intomainfrom
dmceachernmsft/MeetingCompositeOptions
Jan 5, 2022
Merged

Dmceachernmsft/MeetingCompositeOptions#1272
dmceachernmsft merged 18 commits intomainfrom
dmceachernmsft/MeetingCompositeOptions

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

add options prop to the meeting composite.

Why

matches the meeting composites props with the call composite.

How Tested

Work in progress, story book has some current complications with complex props like the options prop.

type to allow further customization.
back to just options in the meeting composite.
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft marked this pull request as ready for review December 23, 2021 01:13
@dmceachernmsft dmceachernmsft changed the title [WIP]Dmceachernmsft/MeetingCompositeOptions Dmceachernmsft/MeetingCompositeOptions Dec 23, 2021
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread packages/communication-react/review/communication-react.api.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2022

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2022

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 4, 2022

if (meetingControls === true) {
// return empty object so buttons in the meetingCallControlOptions set render in their defualt behaviors.
return undefined;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2022

@dmceachernmsft dmceachernmsft merged commit 8562048 into main Jan 5, 2022
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/MeetingCompositeOptions branch January 5, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants