Dmceachernmsft/MeetingCompositeLocaleSidePane#1278
Conversation
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
…gCompositeLocaleSidePane
correct labels.
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alcail,
anjulgarg,
mgamis-msft and
prprabhu-ms
as code owners
| "deliveredTooltipText": "Sent", | ||
| "seenAriaLabel": "Message seen by others", | ||
| "seenTooltipText": "Seen", | ||
| "sendingAriaLabel": "Message sending", |
There was a problem hiding this comment.
Should this be "Sending message" instead?
Actually, "Sent message", "Failed to send message" might also sound better when announced by the narrator.
| "placeholderText": "Nachricht eingeben", | ||
| "textTooLong": "Ihre Nachrichtenlänge überschreitet den maximalen Grenzwert." | ||
| "textTooLong": "Ihre Nachrichtenlänge überschreitet den maximalen Grenzwert.", | ||
| "sendButtonAriaLabel": "Nachricht senden" |
There was a problem hiding this comment.
You don't need to update any of the translated strings. Just the en-US ones. The rest will be updated via autmation / td build.
There was a problem hiding this comment.
I just ran the td build to update the strings to make sure that the logic I wrote was correct.
dmceachernmsft
deleted the
dmceachernmsft/MeetingCompositeLocaleSidePane
branch
4 participants
What
Add locale string use to the side pane in the meeting composite
Why
Complete locale integration into the meeting composite.
How Tested
Ran Locally with locale strings added in the storybook sample.