HorizontalGallery UI tests using MockCallingAdapter#1347
Merged
mgamis-msft merged 58 commits intomainfrom Feb 2, 2022
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
Contributor
Author
It seems like the CI did not the snapshots for localization tests. Because I can see from our dogfood app that the bottom of the icon aligns with the bottom of the text in our buttons. |
Contributor
Contributor
Contributor
prprabhu-ms
approved these changes
Feb 1, 2022
JamesBurnside
approved these changes
Feb 1, 2022
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
This reverts commit c0a7f66.
Contributor
This reverts commit 39e9a99.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MockCallingAdapter. Otherwise an actualCallingAdapteris created usingcreateAzureCommunicationCallAdapterwill be used for the CallComposite.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2686575
How Tested
Running HorizontalGallery.test.ts playwright tests along to check if they consistently pass
Process & policy checklist
Is this a breaking change?