Typeguard icon usage in composites#1533
Merged
JamesBurnside merged 40 commits intomainfrom Mar 1, 2022
Merged
Conversation
…n out of CallCompositeIcons
…thub.com/Azure/communication-ui-library into jaburnsi/add-callwithchat-icon-interface
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
dmceachernmsft
approved these changes
Feb 23, 2022
…chat-icon-interface
…/typeguard-icon-usage-in-composites
Contributor
…on-usage-in-composites
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
…on-usage-in-composites
Contributor
Contributor
Contributor
…/github.com/Azure/communication-ui-library into jaburnsi/typeguard-icon-usage-in-composites
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Download,ChevronLeftandCancelicons to the list of customizable iconsNote: this is only for composites-only icons. It's gets tricky for ensuring react-components icons are listed in the composite icon interfaces (but a problem that should definitely be tackled -- just not in this PR)
Why
<Icon iconName={_name_} />accepts a plain string as an icon name. This means when developing we could enter anything here and we won't know of an issue until runtime (or perhaps far later when a developer tries to customize the icon!).This ensures we hit build time errors when using icons we have not set up to be customized.
How Tested
eslint rule fails build if Icon or FontIcon is used directly:
