Fix eslint warnings - Final (react-composites)#1600
Merged
JamesBurnside merged 3 commits intomainfrom Mar 7, 2022
Merged
Conversation
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
alkwa-msft
approved these changes
Mar 4, 2022
Contributor
prprabhu-ms
reviewed
Mar 7, 2022
| props.styles ?? {} | ||
| ), | ||
| [theme] | ||
| [props.styles, theme.palette.neutralLight] |
Contributor
There was a problem hiding this comment.
nit: I tend to think of theme as an atomic unit. I'd not expect Contoso to modify parts of the theme so it's OK to add theme as the dependency (especially if the list of theme fields we reference starts growing)
prprabhu-ms
reviewed
Mar 7, 2022
| } | ||
| }, | ||
| [props.speakers, props.onSelectSpeaker] | ||
| [speakers, onSelectSpeaker] |
Contributor
There was a problem hiding this comment.
Why did you need to do this?
prprabhu-ms
reviewed
Mar 7, 2022
| * @TODO Remove this function and pass the props directly when file-sharing is promoted to stable. | ||
| * @private | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/explicit-function-return-type |
Contributor
There was a problem hiding this comment.
You can use FileSharingOptions return type. The type is defined unconditionally (the field ChatCompositeOptions.fileSharing is conditionally defined.
prprabhu-ms
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix eslint warnings and fail builds on eslint warnings
NOTE: please review the changes to the react hook dependency arrays closely, these can easily cause regressions.
Why
Continuation of #1597 and #1598
How Tested
I haven't but if please inspect the useEffect dependency changes closely