Update split button border radius#1609
Merged
dmceachernmsft merged 7 commits intomainfrom Mar 9, 2022
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
Member
There was a problem hiding this comment.
this should be minor as it visually impacts stable builds (even more so if contoso has set their own theme.effect.roundercorner2/4 value)
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "none", | |||
| "comment": "Update styles around split button border radius", | |||
Member
There was a problem hiding this comment.
Try be more specific here so Contoso reading the changelogs understands what to expect (e.g. what styles were updated? where are these split buttons that will have updated -- will my app be impacted?) consider: Increase control bar button border radius in Composites with Call features
prprabhu-ms
approved these changes
Mar 8, 2022
edwardlee-msft
approved these changes
Mar 8, 2022
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Increases split button Border radius
Why
Makes the border radius of the buttons match with the Figma designs
https://skype.visualstudio.com/SPOOL/_workitems/edit/2781977
How Tested
Ran locally with visual inspection.