Skip to content

Dmceachernmsft/ContextMenuTestAlignmentFix#1701

Merged
dmceachernmsft merged 12 commits intomainfrom
dmceachernmsft/ContextMenuTestAlignmentFix
Apr 7, 2022
Merged

Dmceachernmsft/ContextMenuTestAlignmentFix#1701
dmceachernmsft merged 12 commits intomainfrom
dmceachernmsft/ContextMenuTestAlignmentFix

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft commented Mar 18, 2022 •
edited
Loading

What

Add sub icon style set

Why

fixes alignment of the subicon in the flyout
Figma:
image
Code:
image

https://skype.visualstudio.com/SPOOL/_workitems/edit/2791165

How Tested

Ran locally and compared against the figmas

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-eiigeeixda.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2022

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-eohwaflcmz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2022

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-tqwxqbbzan.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-swwzeyvfuc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-nwwswvtyrf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2022

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-ebhkrwrahz.chromatic.com/

@JamesBurnside
Copy link
Copy Markdown
Member

JamesBurnside commented Apr 5, 2022

Can you post a screenshot of the result? (or add a UI test that captures this)

JamesBurnside
JamesBurnside reviewed Apr 5, 2022
View reviewed changes
Comment thread change/@internal-react-components-98daf1a6-2477-44dc-bc3d-efb08935e46d.json Outdated
JamesBurnside
JamesBurnside reviewed Apr 5, 2022
View reviewed changes
Comment thread packages/react-components/src/components/styles/ChatMessageComponent.styles.ts Outdated
JamesBurnside
JamesBurnside requested changes Apr 5, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding on understanding the -10px

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-tvjbtiogeg.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-gfsdndzreo.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-dcmtvuxaud.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-oazpafnvta.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2022

Storybook URL https://60c7ae6891f0e90039d7cd54-hprkubindt.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit 692b7f1 into main Apr 7, 2022
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/ContextMenuTestAlignmentFix branch April 7, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@edwardlee-msft edwardlee-msft edwardlee-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft

@anjulgarg anjulgarg Awaiting requested review from anjulgarg

@carocao-msft carocao-msft Awaiting requested review from carocao-msft

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft

@PorterNan PorterNan Awaiting requested review from PorterNan

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft

@prprabhu-ms prprabhu-ms Awaiting requested review from prprabhu-ms

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmceachernmsft @JamesBurnside @edwardlee-msft
⚡