Fix: Prevent floating local video being dragged offscreen in VideoGallery#1725
Merged
JamesBurnside merged 4 commits intomainfrom Mar 30, 2022
Merged
Fix: Prevent floating local video being dragged offscreen in VideoGallery#1725JamesBurnside merged 4 commits intomainfrom
VideoGallery#1725JamesBurnside merged 4 commits intomainfrom
Conversation
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
JamesBurnside
changed the title
VideoGalleryVideoGallery
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
mgamis-msft
reviewed
Mar 29, 2022
| internalState.minPosition = { x: -modalRectangle.left, y: -modalRectangle.top }; | ||
| internalState.maxPosition = { x: modalRectangle.left, y: modalRectangle.top }; | ||
| internalState.minPosition = minDragPosition ?? { x: -modalRectangle.left, y: -modalRectangle.top }; | ||
| internalState.maxPosition = maxDragPosition ?? { x: modalRectangle.left, y: modalRectangle.top }; |
mgamis-msft
approved these changes
Mar 29, 2022
prprabhu-ms
approved these changes
Mar 29, 2022
Contributor
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix floating local video tile going offscreen in
VideoGallery:outbounds.mp4
Why
The issue is because fluent assumes the modal is in the center of the screen when it calculates the bounds, more info: microsoft/fluentui#20122
How Tested
inbounds.mp4
Further bug needing solved
If you resize the screen the bounds need recalculated (not a regression from this PR, just another bug)