ModalPiPiP in mobile CallWithChat set to higher position and fixed bounds.#1748
ModalPiPiP in mobile CallWithChat set to higher position and fixed bounds.#1748mgamis-msft merged 17 commits intomainfrom
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
prabhjot-msft and
prprabhu-ms
as code owners
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| </CallAdapterProvider> | ||
| ); | ||
|
|
||
| const modalLayerHost = document.getElementById(props.modalLayerHostId); |
There was a problem hiding this comment.
Can we instead use callWIthChatCompositeRootDiv.getElementById() instead of document?
If Contoso ever has more than one composite on the page this will break.
@dmceachernmsft recently added a reference to this rootDiv to do the same thing
There was a problem hiding this comment.
I tested this with two composites side by side and it works fine.
https://user-images.githubusercontent.com/79475487/161810214-6cdb126f-2042-4cc0-94a8-940c50e4d316.mp4
This is because the id of the modal layer host is uniquely generated in the CallWithChat composite with useId from '@fluentui/react-hooks'
I could change reference the CallWithChat composite div but it would be another prop that needs to be added to CallWIthChatPane.
There was a problem hiding this comment.
Oh nice! Nope what you have sounds good!
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
3 participants
What
VideoGallery#1725 to react-composites so that ModalPiPiP bounds can be set properly when starting position of Modal is not at the center.Why
How Tested
Tested on local CallWithChat sample:
https://user-images.githubusercontent.com/79475487/161246430-2b33c2ab-abb5-4472-827e-b4692fd4ab9a.mp4
With rtl:
https://user-images.githubusercontent.com/79475487/161247324-74496b2f-7478-43c8-b399-7ffe37f584d6.mp4
Process & policy checklist
Is this a breaking change?