Conversation
…ulgarg/2813271/responsive-attach-file-icon
anjulgarg
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| </Stack> | ||
| )} | ||
| <div style={{ width: '100%' }}> | ||
| <SendBox |
There was a problem hiding this comment.
Are we bringing any of these features to the sendbox component we export?
There was a problem hiding this comment.
Not 100% sure about the best way to do it.
Since the placement of file attach icon is so different for mobile and desktop.
There was a problem hiding this comment.
Yeah not sure either, but can always make this decision when we support rich text as that's when many more changes will be made cc @PorterNan
There was a problem hiding this comment.
Right. That's why I am keeping it simple for now.
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| * @remarks `mobile` is currently only optimized for Portrait mode on mobile devices and does not support landscape. | ||
| * @defaultValue 'desktop' | ||
| */ | ||
| formFactor?: 'desktop' | 'mobile'; |
There was a problem hiding this comment.
when this goes stable we'll have to somehow remember to update storybook docs...
3 participants
What
formFactorprop to chat composite similar to call compositeWhy
To ensure that composite matches figma designs
How Tested
Process & policy checklist
Is this a breaking change?