Conversation
PorterNan
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
| public setCallId(newCallId: string, oldCallId: string): void { | ||
| this.modifyState((draft: CallClientState) => { | ||
| const call = draft.calls[oldCallId]; | ||
| call.id = newCallId; |
There was a problem hiding this comment.
So this means the Call object that we get may not be the most updated call object and we want to apply on the correct Id before we set the Call object to the correct key?
There was a problem hiding this comment.
The id value in state.call.id has never been updated before this fix... Although we only use it in a very extreme case
Since this will be run at for the first callIdChange event, so this code will execute ahead of all the other state change, we should be good to assume customer will always get the right value in state
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
|
Unassigning to remove from attention set. Please reassign if you need another review. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
3 participants
What
Update the call.id in state when call id gets changed
Why
How Tested
Process & policy checklist
Is this a breaking change?