Merged
Conversation
PorterNan
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Contributor
|
Please add a lot of context in the PR description. This is a very hard bug to understand and I'm sure I'll come digging git history to this PR 6 months from today :) I would even soft-suggest leaving a reference to the PR in the comment in the code. |
Contributor
|
Hey, any blockers for this PR? |
Contributor
Contributor
Author
Just updated the PR, it's good to go now :D |
Contributor
Contributor
alkwa-msft
approved these changes
Apr 25, 2022
prprabhu-ms
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix whole composite re-render when the callId gets changed
The callId change event will happen first in stateful client then in adapter, then it generates a small gap that with 2 conflict values in stateful client and adapter, which will make call object totally undefined during this gap.
In this PR we try to sync call.id directly from sdk original call object when there is a state change, which ensure adapter can always find the right call id value.
The diagram to explain why callId gets out of sync(before the fix):
Why
How Tested
Process & policy checklist
Is this a breaking change?