Use theme.semanticColors for error text and border of SendBox#1861
Merged
mgamis-msft merged 8 commits intomainfrom May 11, 2022
Merged
Use theme.semanticColors for error text and border of SendBox#1861mgamis-msft merged 8 commits intomainfrom
mgamis-msft merged 8 commits intomainfrom
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
…d of failed messages" This reverts commit f961b80.
mgamis-msft
changed the title
Contributor
dmceachernmsft
approved these changes
May 5, 2022
prabhjot-msft
approved these changes
May 6, 2022
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SendBoxcomponent and the error text of theInputBoxComponentcomponentWhy
https://skype.visualstudio.com/SPOOL/_workitems/edit/2779691
How Tested
Testing
Sendboxborder andInputBoxComponenttext when there is a system error in storybook:https://user-images.githubusercontent.com/79475487/166894179-3246e245-bc44-4e4e-98d2-590fff29abc0.mp4
Process & policy checklist
Is this a breaking change?