Fix loading spinner size in small containers#1995
Merged
JamesBurnside merged 6 commits intomainfrom Jun 14, 2022
Merged
Conversation
JamesBurnside
requested review from
alkwa-msft,
anjulgarg,
carocao-msft and
dmceachernmsft
as code owners
JamesBurnside
requested review from
PorterNan,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
chriswhilar
approved these changes
Jun 14, 2022
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
alkwa-msft
approved these changes
Jun 14, 2022
Contributor
JamesBurnside
deleted the
jaburnsi/fix-loading-spinner-size-in-small-containers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update loading spinner css to use 5rem at maximum, but scale down if the container scales down
Why
Was too large in small containers
How Tested
See updated UI tests
Quick vid with loaders set to always show:
spinner-sizes.mp4