Fix 1.3.0 release comments#2009
Merged
dmceachernmsft merged 8 commits intomainfrom Jun 23, 2022
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
dmceachernmsft
changed the title
Contributor
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
1 similar comment
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
dmceachernmsft
changed the title
Contributor
joheredi
reviewed
Jun 23, 2022
JamesBurnside
approved these changes
Jun 23, 2022
Contributor
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
edwardlee-msft
approved these changes
Jun 23, 2022
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
dmceachernmsft
added a commit
that referenced
this pull request
Jun 23, 2022
* Update name of string * Change files * fix optional types * Change files * update per comments * update api file per conflicts
dmceachernmsft
added a commit
that referenced
this pull request
Jun 24, 2022
* Fix 1.3.0 release comments (#2009) * Update name of string * Change files * fix optional types * Change files * update per comments * update api file per conflicts * update stable api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update the Name of a CallWithChatComposite string
Why
Fixes the naming to better reflect where the string goes
How Tested
Built locally