Alkwa/fix contextmenu with lots of participants#2034
Merged
alkwa-msft merged 4 commits intomainfrom Jun 29, 2022
Merged
Conversation
…ng the maxHeight for the context menu itself
alkwa-msft
requested review from
JamesBurnside,
PorterNan,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
alkwa-msft
commented
Jun 29, 2022
| /** | ||
| * @private | ||
| */ | ||
| export const defaultParticipantListContainerStyle: ParticipantListStyles = { |
Contributor
Author
There was a problem hiding this comment.
This style was only ever used for this one element and it was messing us up.
alkwa-msft
commented
Jun 29, 2022
| maxWidth: '100%' | ||
| } | ||
| }, | ||
| style: { |
Contributor
Author
There was a problem hiding this comment.
This properly sets the maxHeight of the people context menu to 20rem and when we scroll we won't get odd visual artifacts.
Contributor
Contributor
Calling bundle size is decreased✅.
|
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is decreased✅.
|
JamesBurnside
approved these changes
Jun 29, 2022
Contributor
prabhjot-msft
approved these changes
Jun 29, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When there are too many participants it can mess up how things scroll when there is a divider. The divider and other elements will overlap the participants in the context menu
Why
The max-height css property is incorrectly set on the wrong component. We should be setting it on the context menu as opposed to the stack that contains all of the participant elements
Before:
After:
How Tested
Loaded up a UI component in storybook and added some HTML elements
Process & policy checklist
Is this a breaking change?