Callwithchat mobile: dismissed drawer after device selection by carocao-msft · Pull Request #2115 · Azure/communication-ui-library

carocao-msft · 2022-07-21T16:56:35Z

What

Callwithchat mobile: make drawer dismissed after device selection

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/2896714

Test

Screen.Recording.2022-07-22.at.11.00.58.AM.mov

Screen.Recording.2022-07-22.at.12.16.50.PM.mov

github-actions · 2022-07-21T17:02:45Z

CallWithChat bundle size is increased❗.

Current size: 5486905
Base size: 5486811
Diff size: 94

github-actions · 2022-07-21T17:02:50Z

Storybook URL https://60c7ae6891f0e90039d7cd54-etjykyosvw.chromatic.com/

github-actions · 2022-07-21T17:02:57Z

Chat bundle size is increased❗.

Current size: 5263268
Base size: 5263245
Diff size: 23

github-actions · 2022-07-21T17:03:06Z

Calling bundle size is increased❗.

Current size: 5088312
Base size: 5087383
Diff size: 929

JamesBurnside · 2022-07-21T17:07:06Z

Two things to consider:

The mobile drawer is also used when a participant is clicked in callwithchat - can either add the same manual close logic to when they are clicked too, or consider instead changing the _DrawerMenu itself to trigger close when a menu item (that doesn't have a sub menu) is clicked
We have some UI tests that I think will need the test checks updated to reopen the drawer if the drawer dismisses on click

github-actions · 2022-07-21T17:13:47Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-22T18:50:45Z

Storybook URL https://60c7ae6891f0e90039d7cd54-xixiojfrut.chromatic.com/

github-actions · 2022-07-22T18:59:00Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-22T19:00:06Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

carocao-msft · 2022-07-22T19:07:17Z

Two things to consider:

The mobile drawer is also used when a participant is clicked in callwithchat - can either add the same manual close logic to when they are clicked too, or consider instead changing the _DrawerMenu itself to trigger close when a menu item (that doesn't have a sub menu) is clicked

We have some UI tests that I think will need the test checks updated to reopen the drawer if the drawer dismisses on click

Updated PR with screen recording , verified both participant button and audio/camera selection drawers are dismissed after selection

github-actions · 2022-07-22T19:12:15Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ublfxmffgy.chromatic.com/

github-actions · 2022-07-22T19:15:05Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

…i-library into carocao/BUG2896714

github-actions · 2022-07-22T19:20:34Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-22T19:25:58Z

Storybook URL https://60c7ae6891f0e90039d7cd54-luqszkvdsq.chromatic.com/

github-actions · 2022-07-22T19:27:46Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-22T19:38:07Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

JamesBurnside · 2022-07-22T20:34:37Z

+      props.onLightDismiss();
    },
-    [speakers, onSelectSpeaker]
+    [speakers, onSelectSpeaker, props]


nit: avoid props as this means any prop change will cause this to be recreated.
Instead update the above const { speakers, onSelectSpeaker } = props;
to have the onLightDismiss:
const { speakers, onSelectSpeaker, onLightDismiss } = props;
and put onLightDismiss into the dependency array

^^ I second this as well!

JamesBurnside · 2022-07-22T20:34:57Z

+      props.onLightDismiss();
    },
-    [microphones, onSelectMicrophone]
+    [microphones, onSelectMicrophone, props]


(nit: same here on avoiding props in the dep array)

^^ I second this as well

edwardlee-msft · 2022-07-22T21:25:35Z

+      props.onLightDismiss();
    },
-    [microphones, onSelectMicrophone]
+    [microphones, onSelectMicrophone, props]


^^ I second this as well

edwardlee-msft · 2022-07-22T21:25:51Z

+      props.onLightDismiss();
    },
-    [speakers, onSelectSpeaker]
+    [speakers, onSelectSpeaker, props]


^^ I second this as well!

github-actions · 2022-07-22T21:41:07Z

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-23T03:42:42Z

Storybook URL https://60c7ae6891f0e90039d7cd54-xaqhoakksq.chromatic.com/

github-actions · 2022-07-23T03:43:30Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-25T16:37:35Z

Storybook URL https://60c7ae6891f0e90039d7cd54-zkqxbjbllp.chromatic.com/

github-actions · 2022-07-25T16:38:30Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-25T17:01:19Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-25T17:23:31Z

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot.

github-actions · 2022-07-25T17:41:26Z

Storybook URL https://60c7ae6891f0e90039d7cd54-ehauihmyrm.chromatic.com/

github-actions · 2022-07-25T17:58:07Z

Storybook URL https://60c7ae6891f0e90039d7cd54-fmngffnpyc.chromatic.com/

carocao-msft added 2 commits July 21, 2022 09:53

fix drawer bug'

c3da491

Change files

1a7a5f3

carocao-msft assigned JamesBurnside Jul 21, 2022

carocao-msft requested review from JamesBurnside, alkwa-msft, anjulgarg, dmceachernmsft and edwardlee-msft as code owners July 21, 2022 16:56

carocao-msft assigned edwardlee-msft Jul 21, 2022

carocao-msft requested review from PorterNan, mgamis-msft, prabhjot-msft and prprabhu-ms as code owners July 21, 2022 16:56

update ui test

be14b66

Merge branch 'main' into carocao/BUG2896714

9f49d41

carocao-msft added 2 commits July 22, 2022 12:20

update ui test

1da32ce

Merge branch 'carocao/BUG2896714' of github.com:Azure/communication-u…

f538d31

…i-library into carocao/BUG2896714

JamesBurnside approved these changes Jul 22, 2022

View reviewed changes

JamesBurnside reviewed Jul 22, 2022

View reviewed changes

edwardlee-msft approved these changes Jul 22, 2022

View reviewed changes

update pr

f9bcbbb

Merge branch 'main' into carocao/BUG2896714

54e1e37

carocao-msft enabled auto-merge (squash) July 25, 2022 16:32

Merge branch 'main' into carocao/BUG2896714

a65b341

Merge branch 'main' into carocao/BUG2896714

40d3222

carocao-msft merged commit 8c74438 into main Jul 25, 2022

carocao-msft deleted the carocao/BUG2896714 branch July 25, 2022 18:08

Conversation

carocao-msft commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Test

Uh oh!

github-actions Bot commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CallWithChat bundle size is increased❗.

Uh oh!

github-actions Bot commented Jul 21, 2022

Uh oh!

github-actions Bot commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chat bundle size is increased❗.

Uh oh!

github-actions Bot commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Calling bundle size is increased❗.

Uh oh!

JamesBurnside commented Jul 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 21, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

carocao-msft commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

JamesBurnside Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edwardlee-msft Jul 22, 2022

Choose a reason for hiding this comment

Uh oh!

carocao-msft Jul 23, 2022

Choose a reason for hiding this comment

Uh oh!

JamesBurnside Jul 22, 2022

Choose a reason for hiding this comment

Uh oh!

edwardlee-msft Jul 22, 2022

Choose a reason for hiding this comment

Uh oh!

carocao-msft Jul 23, 2022

Choose a reason for hiding this comment

Uh oh!

edwardlee-msft Jul 22, 2022

Choose a reason for hiding this comment

Uh oh!

edwardlee-msft Jul 22, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 22, 2022

Uh oh!

github-actions Bot commented Jul 23, 2022

Uh oh!

github-actions Bot commented Jul 23, 2022

Uh oh!

github-actions Bot commented Jul 25, 2022

Uh oh!

carocao-msft commented Jul 21, 2022 •

edited

Loading

github-actions Bot commented Jul 21, 2022 •

edited

Loading

github-actions Bot commented Jul 21, 2022 •

edited

Loading

github-actions Bot commented Jul 21, 2022 •

edited

Loading

JamesBurnside commented Jul 21, 2022 •

edited

Loading

carocao-msft commented Jul 22, 2022 •

edited

Loading

JamesBurnside Jul 22, 2022 •

edited

Loading