Click on dialpad call button to call a PSTN user#2168
Merged
carocao-msft merged 24 commits intomainfrom Aug 9, 2022
Merged
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
…-library into carocao/PSTN-call
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
Contributor
Contributor
Contributor
Contributor
…-library into carocao/PSTN-call
Contributor
anjulgarg
approved these changes
Aug 9, 2022
Contributor
dmceachernmsft
approved these changes
Aug 9, 2022
Contributor
Contributor
Contributor
… carocao/PSTN-call
Contributor
Contributor
Contributor
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
As a user, I can call PSTN users using a Dial Pad
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2919161
How Tested
ACS group callwithchat (hide dialpad)
ACS PSTN callwithchat
ACS group calling(hide dialpad)
ACS PSTN call
