Fix react hook console errors#2198
Merged
mgamis-msft merged 4 commits intomainfrom Aug 11, 2022
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
as code owners
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
alkwa-msft
reviewed
Aug 10, 2022
| disabled = disabled || !_usePermissions().cameraButton; | ||
| const permissions = _usePermissions(); | ||
| /* @conditional-compile-remove(rooms) */ | ||
| disabled = disabled || !permissions.cameraButton; |
Contributor
There was a problem hiding this comment.
are these the same but we just want to give them more space?
Contributor
Author
There was a problem hiding this comment.
I believe the logical OR here is conditionally calling a react hook.
alkwa-msft
approved these changes
Aug 10, 2022
prabhjot-msft
approved these changes
Aug 10, 2022
JamesBurnside
approved these changes
Aug 10, 2022
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix _usePermissions usage. Not calling it after a logical AND/OR operator which causes React hook console errors
Why
There are React hook console errors as shown in this video for any type of call.
https://user-images.githubusercontent.com/79475487/184026374-f849fc09-b6bf-4e2c-bc82-4c91dad8dfe4.mp4
How Tested
Local sample app test
Process & policy checklist
Is this a breaking change?