Role based device permissions request in CallComposite#2218
Merged
mgamis-msft merged 17 commits intomainfrom Aug 19, 2022
Merged
Role based device permissions request in CallComposite#2218mgamis-msft merged 17 commits intomainfrom
mgamis-msft merged 17 commits intomainfrom
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
anjulgarg,
carocao-msft,
dmceachernmsft and
edwardlee-msft
as code owners
mgamis-msft
requested review from
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
alkwa-msft
reviewed
Aug 15, 2022
| adapter.queryCameras(); | ||
| adapter.queryMicrophones(); | ||
| adapter.querySpeakers(); | ||
| if (role === 'Consumer') { |
Contributor
There was a problem hiding this comment.
when we stop explicitly passing in our role. How are we going to know our role is consumer so we only ask for audio permissions?
Contributor
Author
There was a problem hiding this comment.
I hope I understand the question correctly. The CallComposite can only know the role is Consumer when it is passed as a prop because that role will be used for the PermissionProvider.
Contributor
PorterNan
reviewed
Aug 15, 2022
| adapter.queryCameras(); | ||
| adapter.queryMicrophones(); | ||
| adapter.querySpeakers(); | ||
| if (role === 'Consumer') { |
Contributor
There was a problem hiding this comment.
I guess we need to conditionally compile this part?
Contributor
Author
There was a problem hiding this comment.
Good catch. Yes we do!
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
prabhjot-msft
approved these changes
Aug 16, 2022
PorterNan
approved these changes
Aug 18, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Porting over code from feature branch to ask device permissions based on role for a Rooms call.
Temporarily using a simplified copy of MockCallAdapter for enzyme test. Will move MockCallAdapter from hermetic tests to fake-backends package in this bug https://skype.visualstudio.com/SPOOL/_workitems/edit/2951482 so that it can be used in the enzyme test.
Why
To have public Calling sample ready to be deployed for testing
How Tested
Tested in local Calling sample
Process & policy checklist
Is this a breaking change?