Fix disabled start call button for consumer#2251
Merged
mgamis-msft merged 7 commits intomainfrom Aug 25, 2022
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
Contributor
PorterNan
reviewed
Aug 23, 2022
PorterNan
approved these changes
Aug 23, 2022
Contributor
prabhjot-msft
approved these changes
Aug 24, 2022
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "ui change" label to the PR for updating the snapshot. |
mgamis-msft
deleted the
mgamis/fix-disabled-start-call-button-for-consumer
branch
prprabhu-ms
reviewed
Oct 21, 2022
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "patch", | |||
Contributor
There was a problem hiding this comment.
This should have been prerelease as rooms is a beta-only feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed logic to disabling start call button. If role permissions do not give access to microphone button then do NOT disable start call button.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2960638
How Tested
Local calling sample
Process & policy checklist
Is this a breaking change?