Show correct end call screen when PSTN user is removed from the call#2295
Merged
Show correct end call screen when PSTN user is removed from the call#2295
Conversation
…moving the final PSTN user
anjulgarg
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
dmceachernmsft
approved these changes
Aug 31, 2022
carocao-msft
approved these changes
Aug 31, 2022
Contributor
PorterNan
reviewed
Aug 31, 2022
| const getCallEndReason = (call: CallState): CallEndReasons => { | ||
| const remoteParticipantsEndedArray = Array.from(Object.values(call.remoteParticipantsEnded)); | ||
| /** | ||
| * Handle the special case in a PSTN call where removing the last user kicks the caller out of the call. |
Contributor
There was a problem hiding this comment.
So PSTN call can't hold the call for just one participant? Every PSTN call needs at least 2 people?
PorterNan
approved these changes
Aug 31, 2022
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Process & policy checklist
Is this a breaking change?