Fix composite elements from disappearing when in the disconnecting stage#2392
Merged
JamesBurnside merged 4 commits intomainfrom Oct 12, 2022
Merged
Fix composite elements from disappearing when in the disconnecting stage#2392JamesBurnside merged 4 commits intomainfrom
JamesBurnside merged 4 commits intomainfrom
Conversation
…hChat control bar disappearing when end call is clicked
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
PorterNan
reviewed
Oct 12, 2022
PorterNan
reviewed
Oct 12, 2022
PorterNan
approved these changes
Oct 12, 2022
Contributor
mgamis-msft
approved these changes
Oct 12, 2022
Contributor
JamesBurnside
added a commit
that referenced
this pull request
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
We recently changed the isInCall behavior which meant we show the video gallery during the transition from incall->disconnecting->disconnected.
This is the correct behavior (to show the video gallery) because during this phase its possible the local user's camera and mic are still active.
However we were accidently hiding the call controls bar and showing video spinners in the remote participant video tiles during this disconnection phase.
How Tested
Locally - video gallery spinners still show but there is a bug on the calling sdk to resolve that and ensure their state is correct: https://skype.visualstudio.com/SPOOL/_workitems/edit/3009282