Add allow camera and microphone access drawer to call composite mobile config screen #2434
Add allow camera and microphone access drawer to call composite mobile config screen #2434carocao-msft merged 23 commits intomainfrom
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
anjulgarg,
dmceachernmsft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Chat bundle size is increased❗.
|
CallWithChat bundle size is increased❗.
|
Calling bundle size is increased❗.
|
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
|
||
| { | ||
| /* @conditional-compile-remove(call-readiness) */ | ||
| mobileView && isDrawerShowing && ( |
There was a problem hiding this comment.
if they've already accepted permissions and don't need to accept permissions, will this still always show when joining a call?
There was a problem hiding this comment.
Yes same with enable mic/camera buttons
There was a problem hiding this comment.
We've discussed this offline and will iterate on this behavior
…ions to storybook. Update `html-to-parser` version (#2428) Co-authored-by: Prathmesh Prabhu <82062616+prprabhu-ms@users.noreply.github.com>
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
5 participants
What
Add allow camera and microphone access drawer to call composite mobile config screen
Why
users can click on allow access to receive device permission prompt
before this implementation we don't have anyway to prompt for access on mobile
How Tested
drawer.mov
Also tested by setting callreadinessoptin to false in app.tsx and verified the feature disappears
Accessibility tested