Remove icon re-registered warning from all 3 composites and storybook landing page#2506
Merged
carocao-msft merged 9 commits intomainfrom Nov 9, 2022
Merged
Conversation
carocao-msft
requested review from
alkwa-msft,
anjulgarg,
dmceachernmsft and
edwardlee-msft
as code owners
carocao-msft
requested review from
JamesBurnside,
PorterNan,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
JamesBurnside
approved these changes
Nov 9, 2022
Contributor
Contributor
anjulgarg
approved these changes
Nov 9, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove icon re-registered warning from all 3 composites and storybook landing page
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3043083
How Tested
Go to each sample and see if you can see icon reregistered warnings
For calling and callwithchat, the only reregister warning you should be able to see is for icon 'BackSpace', this is due to needing to register backspace icon in HomeScreen.tsx outside of call composite. Remove registerIcons in homescreen then you should not be able to see any reregister warning=> if contoso is only using Call Composite/ Call with chat composite, should not see warnings
For chat you can still see reregister warning, which is coming from ChatHeader component outside of chat composite. the warning should disappear when ChatHeader is removed => if contoso is only using Chat Composite, should not see warnings
For storybook should not see reregister warning on landing page, but still can see reregister warning for composite stories due to needing to register icons for storybook preview and register icons inside composites
Process & policy checklist
Is this a breaking change?