Skip to content

[A11y bug] Participant changed announcements mk 2#2546

Merged
dmceachernmsft merged 77 commits intomainfrom
prprabhu/announce-participants-only-named
Nov 28, 2022
Merged

[A11y bug] Participant changed announcements mk 2#2546
dmceachernmsft merged 77 commits intomainfrom
prprabhu/announce-participants-only-named

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Introduces narrator announcements for when participants change in the call

Why

allows users in a call using narrator to know when participants come and go from a call.

https://skype.visualstudio.com/SPOOL/_workitems/edit/3007443

How Tested

With the wonderful guidance of @prprabhu-ms we created a series of tests to ensure the output of the hook is correct when participants come in go in different combinations

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small extra comments and some existing ones to resolve but overall looks great! Thanks for doing all these iterations to get this in the best state for our a11y users!

Comment thread packages/react-composites/src/composites/CallComposite/utils/MediaGalleryUtils.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread packages/react-composites/src/composites/CallComposite/utils/MediaGalleryUtils.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft merged commit d7cafbd into main Nov 28, 2022
@dmceachernmsft dmceachernmsft deleted the prprabhu/announce-participants-only-named branch November 28, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants