bugfix: Do not show stale errors when a user rejoins a call#2549
Merged
prprabhu-ms merged 11 commits intomainfrom Nov 23, 2022
Merged
bugfix: Do not show stale errors when a user rejoins a call#2549prprabhu-ms merged 11 commits intomainfrom
prprabhu-ms merged 11 commits intomainfrom
Conversation
prprabhu-ms
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
prprabhu-ms
assigned
JamesBurnside,
dmceachernmsft and
PorterNan and unassigned
JamesBurnside
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
dmceachernmsft
approved these changes
Nov 23, 2022
prprabhu-ms
commented
Nov 23, 2022
Contributor
PorterNan
reviewed
Nov 23, 2022
PorterNan
approved these changes
Nov 23, 2022
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Before this PR, stale errors were sometimes shown in composites via error bar when a user rejoins a call.
Repro steps:
CallCompositeorCallWithChatCompositeThis PR adds a prop to the
ErrorBarcomponent,ignorePremountErrors. When set, the component does not show errors that occurred before the component was mounted.The composites set this prop so that errors from previous calls are ignored.
How Tested