[Call Readiness] Unsupported browser version UI#2552
Merged
dmceachernmsft merged 28 commits intomainfrom Nov 30, 2022
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft and
edwardlee-msft
as code owners
dmceachernmsft
requested review from
PorterNan,
mgamis-msft,
prabhjot-msft and
prprabhu-ms
as code owners
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
Contributor
dmceachernmsft
commented
Nov 28, 2022
| export const UnsupportedBrowserPage = (props: UnsupportedBrowserPageProps): JSX.Element => { | ||
| /* @conditional-compile-remove(unsupported-browser) */ | ||
| const { onTroubleshootingClick } = props; | ||
| const { onTroubleshootingClick, environmentInfo } = props; |
Member
Author
There was a problem hiding this comment.
All of the CC is needed in this file because the EnvironmentInfo type is from the beta calling SDK only so will cause errors in the stable flavor if present. This trickles down to all the other CC elements as well.
Contributor
Contributor
Contributor
mgamis-msft
reviewed
Nov 29, 2022
mgamis-msft
reviewed
Nov 29, 2022
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
edwardlee-msft
approved these changes
Nov 29, 2022
Contributor
mgamis-msft
approved these changes
Nov 30, 2022
dmceachernmsft
deleted the
dmceachernmsft/unsupported-browser-version
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add new UI for showing in unsupportedBrowser version in components and composites.
Why
Allows user to know their browser version is out of date.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3054307
How Tested
Added new components to storybook and tested composite changes in browser stack.