[Call Readiness] Allow unsupported browser version users to join a call#2581
Merged
dmceachernmsft merged 33 commits intomainfrom Dec 12, 2022
Merged
[Call Readiness] Allow unsupported browser version users to join a call#2581dmceachernmsft merged 33 commits intomainfrom
dmceachernmsft merged 33 commits intomainfrom
Conversation
dmceachernmsft
requested review from
alkwa-msft,
anjulgarg and
carocao-msft
as code owners
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Chat bundle size is increased❗.
|
…hub.com/Azure/communication-ui-library into dmceachernmsft/browser-version-continue
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
carocao-msft
reviewed
Dec 9, 2022
| <UnsupportedBrowserVersion | ||
| onTroubleshootingClick={() => alert('clicked compatibility link')} | ||
| strings={unsupportedBrowserVersionStrings} | ||
| onContinueClick={() => alert('you are brave arent you?')} |
carocao-msft
approved these changes
Dec 9, 2022
Contributor
Contributor
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
JamesBurnside
approved these changes
Dec 12, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
2022-12-07.17-07-04.mp4
Introduce new button and logic to unsupported browser version screen in Call and CallWithChat composite
Why
Allows end users to be enabled to enter a call with a old version of a browser should they so choose.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3054310
How Tested
Tested locally in debugger. see above video!