Fix chat pane problem when no parent height is set#2596
Merged
Conversation
PorterNan
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
…ure/communication-ui-sdk into jinan/fix-default-chat-height
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
edwardlee-msft
approved these changes
Dec 15, 2022
Contributor
edwardlee-msft
left a comment
edwardlee-msft
left a comment
There was a problem hiding this comment.
Very nice! Great find Nan
alkwa-msft
approved these changes
Dec 15, 2022
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is the best minimum way to introduce as less change as possible, it based on these facts:
Why 100% not working - because there is no parent item to tell the child div what the 100% is (especially when the parent flex box height is set to auto). Set the root element height will help with this scenario
Before:
After:
Why
How Tested
Process & policy checklist
Is this a breaking change?