Replaced the logic of to/fromFlatCommunicationIdentifier with communication-common#2614
Merged
JamesBurnside merged 6 commits intomainfrom Jan 6, 2023
Merged
Replaced the logic of to/fromFlatCommunicationIdentifier with communication-common#2614JamesBurnside merged 6 commits intomainfrom
JamesBurnside merged 6 commits intomainfrom
Conversation
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Contributor
Contributor
JamesBurnside
approved these changes
Jan 6, 2023
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
PorterNan
approved these changes
Jan 6, 2023
Contributor
mgamis-msft
added a commit
that referenced
this pull request
Jan 7, 2023
…VideoTileMenu` prop to CallCompositeOptions. (#2611) * Added remoteVideoTileMenuOptions prop and removed showRemoteVideoTileContextualMenu prop in VideoGallery. Added showRemoteVideoTileMenu prop to CallCompositeOptions. * Change files * lint fix: added missing hook dependency * conditional compilation fix * fix TSDoc * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update VideoTileDrawerMenuProps.hostId doc Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * prop rename type -> kind. RemoteVideoTileMenuOptions interface added for CallCompositeOptions prop. * revert unintended Calling mobile snapshots * small doc fix * remove console log code * Alkwa/update js storybook (#2127) * updating non-react docs to better support devs * Change files * updated with Prathmeshs suggestions * updating documentation to make (more) sense to developers * fixed some naming and updated with another tip * lets just use vanilla JS for now * some extra cleanup * further cleanup and resolve PR comments Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * Use CallKind from sdk in Call DTO (#2592) * Use CallKind from sdk in Call DTO Co-authored-by: Nan Jiang <jinan@microsoft.com> * Replaced the logic of to/fromFlatCommunicationIdentifier with communication-common (#2614) Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> * Using drawer menu host id in remoteVideoTileMenuOptions prop of VideoGallery Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Anjul Garg <anjulgarg@live.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: alkwa-msft <79329532+alkwa-msft@users.noreply.github.com> Co-authored-by: Porter Nan <jiangnanhello@live.com> Co-authored-by: Nan Jiang <jinan@microsoft.com> Co-authored-by: Petr Švihlík <rocky.intel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Process & policy checklist
Is this a breaking change?