Skip to content

Scrollable horizontal gallery when VideoGallery is narrow#2640

Merged
mgamis-msft merged 35 commits intomainfrom
mgamis/scrollable-horizontal-gallery
Jan 14, 2023
Merged

Scrollable horizontal gallery when VideoGallery is narrow#2640
mgamis-msft merged 35 commits intomainfrom
mgamis/scrollable-horizontal-gallery

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

@mgamis-msft mgamis-msft commented Jan 8, 2023

What

Change paginated horizontal gallery with navigation buttons to scrollable horizontal gallery when VideoGallery is narrow.

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3094701

How Tested

Local Calling sample. UI snapshots for Calling mobile should be updated.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-flqvenofho.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 5886415
  • Base size: 5880990
  • Diff size: 5425

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 5586238
  • Base size: 5585907
  • Diff size: 331

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 5501923
  • Base size: 5496497
  • Diff size: 5426

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 8, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-nxuxyjzygz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-sgpwwypoii.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 12, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 12, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-xqthbxrqjf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 12, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ticlfdkckc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 13, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ngdrcgyrbq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 13, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-klyueiromi.chromatic.com/

dmceachernmsft
dmceachernmsft approved these changes Jan 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool functions for dragging the horizontal Gallery!

@mgamis-msft
Copy link
Copy Markdown
Contributor Author

mgamis-msft commented Jan 13, 2023 •
edited
Loading

I am aware that A11y team can raise issues about the lack of a scrollbar for the ScrollableHorizontalGallery. Alex P intends for there to be no scrollbar and points to Teams as an example where no scrollbar is present. If the A11y team, raises an issue we will address it by adding an appropriate scrollbar.

@dmceachernmsft dmceachernmsft added update_snapshots Set this label to request automated update of UI snapshots and removed update_snapshots Set this label to request automated update of UI snapshots labels Jan 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-aqwvjuajon.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft force-pushed the mgamis/scrollable-horizontal-gallery branch from 58f6291 to 2e62756 Compare January 14, 2023 01:01
@mgamis-msft mgamis-msft enabled auto-merge (squash) January 14, 2023 01:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ewpbxtqnvp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Jan 14, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Jan 14, 2023
@mgamis-msft mgamis-msft disabled auto-merge January 14, 2023 09:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 14, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-xfxjaqlkfq.chromatic.com/

@mgamis-msft mgamis-msft merged commit 18b0626 into main Jan 14, 2023
@mgamis-msft mgamis-msft deleted the mgamis/scrollable-horizontal-gallery branch January 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft

@anjulgarg anjulgarg Awaiting requested review from anjulgarg

@carocao-msft carocao-msft Awaiting requested review from carocao-msft

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft

@PorterNan PorterNan Awaiting requested review from PorterNan

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft

Assignees

@JamesBurnside JamesBurnside

@dmceachernmsft dmceachernmsft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgamis-msft @JamesBurnside @dmceachernmsft
⚡