[BugFix] Add isCameraOn to CallAdapter state#2641
Merged
dmceachernmsft merged 13 commits intomainfrom Jan 10, 2023
Merged
Conversation
dmceachernmsft
requested review from
alkwa-msft,
anjulgarg and
carocao-msft
as code owners
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
edwardlee-msft and
mgamis-msft
as code owners
…hub.com/Azure/communication-ui-library into dmceachernmsft/cameraAndMicAdapterState
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
JamesBurnside
approved these changes
Jan 9, 2023
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
Small change to avoid using getState as this will be a stale value to the one passed into setState fn, but otherwise looks great! Really like this change as it was a big gap for me during the hackathon
…hub.com/Azure/communication-ui-library into dmceachernmsft/cameraAndMicAdapterState
Contributor
PorterNan
reviewed
Jan 9, 2023
PorterNan
approved these changes
Jan 9, 2023
Contributor
PorterNan
left a comment
PorterNan
left a comment
There was a problem hiding this comment.
Just a minor comment about naming for future proof, this looks good to me
Contributor
PorterNan
reviewed
Jan 10, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add new state tracking local participants camera state to the CallAdapter
Why
Allows Contoso to have better state control of the camera should they want to do something based on it like create their own custom control bar for the CallComposite.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3048158
How Tested
Ran samples locally checking whether the state of the camera was being reflected appropriately in new variable.