Added display name heading to remote video tile drawer menu #2646
Merged
mgamis-msft merged 6 commits intomainfrom Jan 12, 2023
Merged
Added display name heading to remote video tile drawer menu #2646mgamis-msft merged 6 commits intomainfrom
mgamis-msft merged 6 commits intomainfrom
Conversation
…me as remote video tile drawer menu heading
mgamis-msft
requested review from
alkwa-msft,
anjulgarg and
carocao-msft
as code owners
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
as code owners
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
JamesBurnside
approved these changes
Jan 11, 2023
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
This is great! Can you update the internal storybook stories for the drawer with a header example?
Contributor
dmceachernmsft
approved these changes
Jan 11, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added display name heading to remote video tile drawer menu
Why
Figma specs for remote video tile drawer menu
How Tested
Tested locally
UI snapshot tests pending
Process & policy checklist
Is this a breaking change?