[BugFix] Fix icon placement in configuration screen warning bars#2649
Merged
dmceachernmsft merged 5 commits intomainfrom Jan 12, 2023
Merged
[BugFix] Fix icon placement in configuration screen warning bars#2649dmceachernmsft merged 5 commits intomainfrom
dmceachernmsft merged 5 commits intomainfrom
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
carocao-msft
approved these changes
Jan 12, 2023
Contributor
Calling bundle size is increased❗.
|
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
prabhjot-msft
approved these changes
Jan 12, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move icons down to be more in line with text
Why
fixes alignment issue
https://skype.visualstudio.com/SPOOL/_workitems/edit/3086736 using to track icons since text is fixed
How Tested
Ran locally, will generate snapshots