Fix rerender of VideoGallery when first participant is pinned#2650
Merged
mgamis-msft merged 8 commits intomainfrom Jan 17, 2023
Merged
Fix rerender of VideoGallery when first participant is pinned#2650mgamis-msft merged 8 commits intomainfrom
mgamis-msft merged 8 commits intomainfrom
Conversation
…ionally added to FloatingLocalVideoLayout and DefaultLayout
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
as code owners
Contributor
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Contributor
prabhjot-msft
approved these changes
Jan 16, 2023
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
mgamis-msft
force-pushed
the
mgamis/cleanup-layout-code
branch
from
2751854 to
b131801
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Problem:
The rerender occurs because the VideoGallery is switching between PinnedParticipantLayout and FloatingLocalVideoLayout causing all the remote video tiles to be rerendered.
Solution:
Do pinned participant logic in FloatingLocalVideoLayout and DefaultLayout. Remove PinnedParticipantLayout
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3104069
How Tested
Local sample testing
https://user-images.githubusercontent.com/79475487/212332894-85fa0706-54d8-40ef-b863-0fd0b6a80945.mp4
Process & policy checklist
Is this a breaking change?