Added missing arial label for title in this call#2667
Merged
carocao-msft merged 4 commits intomainfrom Jan 20, 2023
Merged
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
dmceachernmsft,
edwardlee-msft and
mgamis-msft
as code owners
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
dmceachernmsft
approved these changes
Jan 20, 2023
edwardlee-msft
approved these changes
Jan 20, 2023
Contributor
edwardlee-msft
left a comment
edwardlee-msft
left a comment
There was a problem hiding this comment.
I did notice that FluentUI's example, ContextualMenu With Header, also does not read out the title.
https://developer.microsoft.com/en-us/fluentui#/controls/web/contextualmenu#IContextualMenuItem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added missing arial label for title in this call
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2756584
How Tested
loaded up samples and check with voice over
Process & policy checklist
Is this a breaking change?