[BugFix] Update error bar selector for when camera is already in use#2671
Merged
dmceachernmsft merged 6 commits intomainfrom Jan 25, 2023
Merged
[BugFix] Update error bar selector for when camera is already in use#2671dmceachernmsft merged 6 commits intomainfrom
dmceachernmsft merged 6 commits intomainfrom
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
JamesBurnside
approved these changes
Jan 24, 2023
carocao-msft
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update error bar messaging in Call and config screens for when camera is in use already
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3030591
How Tested
Ran locally with camera app stealing camera.
Also checked in with Calling to validate the different cases when the error for video failed is being surfaced.