Fix race condition logic in createView and disposeView where a remote video tile may fail to create a view.#2672
Merged
JamesBurnside merged 3 commits intomainfrom Jan 24, 2023
Conversation
… video tile may fail to create a view.
JamesBurnside
requested review from
PorterNan,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
dmceachernmsft
approved these changes
Jan 24, 2023
edwardlee-msft
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Apply #2558 fix to remoteVideoView
(Fix race condition logic in createView and disposeView where a remote video tile may fail to create a view.)
Why
Race condition logic from #2558 still exists
How Tested
We cannot reproduce the race condition logic locally, but hopefully this will reduce/eliminate the rare BRB bug where video participant could not be seen.
Played around locally with multiple participants, turning off/on videos and screenshares and verified that non-of the normal remote video renderings appeared to be broken