Add total participant count to stateful client#2679
Merged
JamesBurnside merged 6 commits intomainfrom Jan 27, 2023
Merged
Conversation
JamesBurnside
requested review from
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft and
edwardlee-msft
as code owners
JamesBurnside
requested review from
PorterNan,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
PorterNan
approved these changes
Jan 25, 2023
carocao-msft
approved these changes
Jan 27, 2023
Contributor
JamesBurnside
deleted the
jaburnsi/add-total-participant-count-to-stateful-client
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Call object's
totalParticipantCountto stateful clientWhy
RemoteParticipants array maxes out at 100. TotalParticipantCount allows for UI affordance to show when there are more participants than that and display some sort of "+X more"
How Tested
From testing, I saw that if you are the only person in the call the
totalParticipantCountis undefined, here is the logs when someone joined, went from undefined (only me in the call), to two:otherwise was reporting as expected, participant joins:
participant leaves:
