[Bugfix][a11y] Fixed leave chat state is not announced by Screen Reader#2681
Merged
Leah-Xia-Microsoft merged 10 commits intomainfrom Feb 7, 2023
Merged
[Bugfix][a11y] Fixed leave chat state is not announced by Screen Reader#2681Leah-Xia-Microsoft merged 10 commits intomainfrom
Leah-Xia-Microsoft merged 10 commits intomainfrom
Conversation
Leah-Xia-Microsoft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
dmceachernmsft
approved these changes
Feb 3, 2023
Leah-Xia-Microsoft
requested review from
JoshuaLai,
emlynmac,
jimchou-dev,
palatter and
vhuseinova-msft
emlynmac
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The status message should be announced by Screen Reader after leaving chat. Screen Reader should announce as "You left the Chat" as seen visually.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/2881374
How Tested
Tested on Mac with Chrome and Safari
Process & policy checklist
Is this a breaking change?