[BugFix] update errorbar selector to no longer incorrectly indicate user is on mac#2691
Merged
dmceachernmsft merged 11 commits intomainfrom Feb 2, 2023
Merged
[BugFix] update errorbar selector to no longer incorrectly indicate user is on mac#2691dmceachernmsft merged 11 commits intomainfrom
dmceachernmsft merged 11 commits intomainfrom
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
carocao-msft
reviewed
Feb 1, 2023
carocao-msft
approved these changes
Feb 1, 2023
Contributor
JamesBurnside
approved these changes
Feb 2, 2023
dmceachernmsft
added a commit
that referenced
this pull request
Feb 2, 2023
…ser is on mac (#2691) * update Errorbar selector to be protective of mac * Change files * Duplicate change files for beta release * Move CC into logic so we still see error in stable * remove console log * updating strings for generic cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Error bar will validate the user is on mac and show correct message. stable flavor just show generic message
Why
Error bar no longer tells android or windows user they are on macOS and their camera is blocked
https://skype.visualstudio.com/SPOOL/_workitems/edit/3124414
How Tested
Validated locally issue does not happen anymore on windows and android. tested on mac using browserstack errors still showed mac strings