Fix for navigation using keyboard to activate the video tile context men#2693

Merged

prabhjot-msft merged 19 commits intomainfrom

prabhjot/vgl-tab-navigation

Feb 7, 2023

Contributor

prabhjot-msft commented Feb 1, 2023

What

Added empty icon render for tab navigation of video tile

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3123445

Screen.Recording.2023-01-31.at.10.02.28.PM.mov

How Tested

Process & policy checklist

I have updated the project documentation to reflect my changes if necessary.
I have read the CONTRIBUTING documentation.

Is this a breaking change?

This change causes current functionality to break.

prabhjot-msft added 3 commits

February 1, 2023 05:51


          Added empty icon render for tab navigation of video tile

b62793d


          Change files

16302c6


          Duplicate change files for beta release

e976a96

prabhjot-msft requested review from JamesBurnside, PorterNan, alkwa-msft, anjulgarg, carocao-msft, dmceachernmsft, edwardlee-msft and mgamis-msft as code owners

February 1, 2023 06:05

prabhjot-msft assigned JamesBurnside and carocao-msft

Contributor

github-actions Bot commented Feb 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ipszhcddme.chromatic.com/

Contributor

github-actions Bot commented Feb 1, 2023 •

edited

Loading

Calling bundle size is increased❗.

Current size: 5561473
Base size: 5561374
Diff size: 99

Contributor

github-actions Bot commented Feb 1, 2023 •

edited

Loading

CallWithChat bundle size is increased❗.

Current size: 5945746
Base size: 5945647
Diff size: 99

Contributor

github-actions Bot commented Feb 1, 2023 •

edited

Loading

Chat bundle size is increased❗.

Current size: 5644139
Base size: 5644040
Diff size: 99

JamesBurnside reviewed

View reviewed changes

packages/react-components/src/components/VideoTile.tsx Outdated

                   return <></>;
                 }
+                const optionsIcon = canShowContextMenuButton ? 'VideoTileMoreOptions' : 'VideoTileHideOptionsIcon';

Member

JamesBurnside Feb 1, 2023

What is the purpose behind the VideoTileHideOptionsIcon ? Are we unable to not render the <IconButton when canShowContextMenuButton is false?

Contributor Author

prabhjot-msft Feb 1, 2023

It renders the icon button without any icon, so the button is there and it can be navigated using keyboard to activate the context menu. We use similar solution for participant Item where the ellipsis appear on hover.

dmceachernmsft approved these changes

View reviewed changes


          Merge branch 'main' into prabhjot/vgl-tab-navigation

9226fef

Contributor

github-actions Bot commented Feb 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-oqmeeumxlx.chromatic.com/

prabhjot-msft added 2 commits

February 2, 2023 06:39


          Updated API.md files

92c634d


          Merge branch 'main' into prabhjot/vgl-tab-navigation

fc0b900

Contributor

github-actions Bot commented Feb 2, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-zdpnwgmlmx.chromatic.com/

Contributor

github-actions Bot commented Feb 2, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions Bot commented Feb 2, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

prabhjot-msft added 3 commits

February 2, 2023 19:31


          minor changes

264c3f8


          Merge branch 'main' of https://github.com/Azure/communication-ui-library

13312e9

 into prabhjot/vgl-tab-navigation


          Merge branch 'prabhjot/vgl-tab-navigation' of https://github.com/Azur…

b020360

…e/communication-ui-library into prabhjot/vgl-tab-navigation

Contributor

github-actions Bot commented Feb 2, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-jjsmvqfddi.chromatic.com/

Contributor

github-actions Bot commented Feb 2, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions Bot commented Feb 2, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Contributor

github-actions Bot commented Feb 2, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

prabhjot-msft added the update_snapshots label

github-actions Bot removed the update_snapshots label


          Merge branch 'main' into prabhjot/vgl-tab-navigation

Contributor

github-actions Bot commented Feb 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-mqkmuchjdo.chromatic.com/

Contributor

github-actions Bot commented Feb 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

prabhjot-msft added the update_snapshots label

github-actions Bot removed the update_snapshots label

mgamis-msft approved these changes

View reviewed changes

Contributor

github-actions Bot commented Feb 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.


          Merge branch 'main' into prabhjot/vgl-tab-navigation

f2d2c34

Contributor

github-actions Bot commented Feb 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-bjbpukeuqz.chromatic.com/

Contributor

github-actions Bot commented Feb 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

prabhjot-msft added the update_snapshots label

github-actions Bot removed the update_snapshots label

prabhjot-msft added 5 commits

February 3, 2023 23:36


          Merge branch 'main' of https://github.com/Azure/communication-ui-library

70442cc

 into prabhjot/vgl-tab-navigation


          Merge branch 'main' of https://github.com/Azure/communication-ui-library

9c759f1

 into prabhjot/vgl-tab-navigation


          Updated test file

cda06b7


          Merge branch 'main' of https://github.com/Azure/communication-ui-library

b28dd7f

 into prabhjot/vgl-tab-navigation


          Merge branch 'prabhjot/vgl-tab-navigation' of https://github.com/Azur…

f1bb12d

…e/communication-ui-library into prabhjot/vgl-tab-navigation

prabhjot-msft added the update_snapshots label

github-actions Bot removed the update_snapshots label

Contributor

github-actions Bot commented Feb 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-jvohrpblue.chromatic.com/

Contributor

github-actions Bot commented Feb 7, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.


          Update packages/react-composites CallComposite browser test snapshots

1bd2223

Contributor

github-actions Bot commented Feb 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-pfprwipgzz.chromatic.com/

prabhjot-msft merged commit 237bf5f into main

prabhjot-msft deleted the prabhjot/vgl-tab-navigation branch

February 7, 2023 02:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JamesBurnside JamesBurnside approved these changes

mgamis-msft mgamis-msft approved these changes

dmceachernmsft dmceachernmsft approved these changes

alkwa-msft Awaiting requested review from alkwa-msft

anjulgarg Awaiting requested review from anjulgarg

carocao-msft Awaiting requested review from carocao-msft

edwardlee-msft Awaiting requested review from edwardlee-msft

PorterNan Awaiting requested review from PorterNan

Labels

None yet

⚡