Add parameter to hint displayName from SDK#2697
Merged
Conversation
PorterNan
requested review from
JamesBurnside,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
JamesBurnside
approved these changes
Feb 5, 2023
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
This a great solution to make Contoso know what to provide! Love it!
edwardlee-msft
approved these changes
Feb 7, 2023
Contributor
PorterNan
added a commit
that referenced
this pull request
Feb 21, 2023
* Add parameter to hint displayName from SDK --------- Co-authored-by: Nan Jiang <jinan@microsoft.com>
edwardlee-msft
pushed a commit
that referenced
this pull request
Feb 23, 2023
* Update storybook for cte display name (#2766) * Add code snippet for displayName override --------- Co-authored-by: Nan Jiang <jinan@microsoft.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> * Add parameter to hint displayName from SDK (#2697) * Add parameter to hint displayName from SDK --------- Co-authored-by: Nan Jiang <jinan@microsoft.com> --------- Co-authored-by: Nan Jiang <jinan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add parameter to hint displayName from SDK, so Contoso doesn't have to override it if there is any from sdk
Why
How Tested
Process & policy checklist
Is this a breaking change?